Segmentation: add preview/unsupported build selection controls#32
Open
godnight10061 wants to merge 3 commits intoeasydiffusion:mainfrom
Open
Segmentation: add preview/unsupported build selection controls#32godnight10061 wants to merge 3 commits intoeasydiffusion:mainfrom
godnight10061 wants to merge 3 commits intoeasydiffusion:mainfrom
Conversation
Contributor
|
Thanks @godnight10061! What made you decide to use different flags for the various gates rather than a single |
Contributor
Author
|
Good question — the gates are intentionally orthogonal, so separate flags let you tweak one dimension without implicitly changing the others (handy for debugging and incremental rollout). That said, we agreed the “common path” should be simpler, so I added a The individual flags are still there so advanced users/CI can override specific gates when needed without fighting a single coarse policy knob. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #25
This adds build-selection knobs (now including
--policypresets) so app developers can opt into preview wheels and/or fail fast on EOL/unsupported stacks.Changes:
get_torch_platform(..., preview=False, unsupported=True)gating:preview=Falseavoids preview-only recommendations (Navi 4x falls back to CPU;preview=Trueselectsrocm6.4).unsupported=Falseerrors on EOL/unsupported selections (directml,ipex,rocm4.2,rocm5.2).install(...)and CLI:--policy {compat,stable,preview}(alias:nightly) sets presets for(preview, unsupported).--policy-> explicit flags (--preview,--no-unsupported).--previewenables preview/test/nightly installs;--no-unsupportedturns EOL/unsupported selections into an error./whl/xpuby default;--previewswitches to/whl/test/xpu.nightly/*installs require preview.Test plan:
python -m pytest -q